Re: Add new functions to mark/unmark/delete all bookmarks

[Karl Fogel]

Hi, Matthew.  I had a chance to try out your latest patch for 'master'.  Note I 
only tried that one, since this change will go onto 'master' and not onto 
'emacs-27'.

When I tested manually, everything works fine: marking all, unmarking all, 
deleting, everything's good.  However, bookmark shows one test failure now in 
'make check':

  FAILED   2/47  bookmark-test-bmenu-any-marks-list (0.000279 sec)

I haven't had time to investigate further yet, but I wanted to know if you're 
also seeing the same failure?  I applied your patch using 'git am'.  Below are 
HEAD and HEAD^ in my tree, so you can see exactly what code I'm testing with:

  > commit 23faf0e8d4daac5cc9c199efe97fa36c9d4691b6
  > Author:     Matthew White <mehw.is.me@inventati.org>
  > AuthorDate: Thu Jul 23 21:14:32 2020 +0000
  > Commit:     Karl Fogel <kfogel@red-bean.com>
  > CommitDate: Tue Jul 28 21:10:45 2020 -0500
  > 
  >     Add ability to mark/unmark/delete all bookmarks
  >     
  >     * lisp/bookmark.el (bookmark-delete-all): New function to delete all
  >       bookmarks.
  >       (bookmark-bmenu-mark-all): New function to mark all bookmarks in the
  >       bookmark list buffer.
  >       (bookmark-bmenu-unmark-all): New function to unmark all bookmarks in
  >       the bookmark list buffer.
  >       (bookmark-bmenu-delete-all): New function to mark for deletion all
  >       bookmarks in the bookmark list buffer.
  >       (bookmark-map): Map "D" to `bookmark-delete-all'.
  >       (bookmark-bmenu-mode-map): New mappping for "M" to
  >       `bookmark-bmenu-mark-all'.
  >       (bookmark-bmenu-mode-map): New mappping for "U" to
  >       `bookmark-bmenu-unmark-all'.
  >       (bookmark-bmenu-mode-map): New mappping for "D" to
  >       `bookmark-bmenu-delete-all'.
  >       (bookmark-bmenu-mark-all): New bookmark menu to
  >       `bookmark-delete-all'.
  >       (easy-menu-define): New bookmark menu to `bookmark-bmenu-mark-all'.
  >       (easy-menu-define): New bookmark menu to
  >       `bookmark-bmenu-unmark-all'.
  >       (easy-menu-define): New bookmark menu to
  >       `bookmark-bmenu-delete-all'.
  >       (bookmark-bmenu-select): Update docstring to include a reference to
  >       `bookmark-bmenu-mark-all'.
  >       (bookmark-bmenu-mode): Update docstring. Add/Update description:
  >       `bookmark-bmenu-mark-all', `bookmark-bmenu-delete-all',
  >       `bookmark-bmenu-execute-deletions', and `bookmark-bmenu-unmark-all'.
  >     * test/lisp/bookmark-resources/test-list.bmk: New bookmark file to
  >       test a list of bookmarks.
  >     * test/lisp/bookmark-tests.el (bookmark-tests-bookmark-file-list): New
  >       reference to the bookmark file used for testing a list of bookmarks.
  >       (bookmark-tests-bookmark-list-0, bookmark-tests-bookmark-list-1,
  >       bookmark-tests-bookmark-list-2): New cached values for testing a
  >       list of bookmark.
  >       (bookmark-tests-cache-timestamp-list): New variable to set
  >       `bookmark-bookmarks-timestamp'.
  >       (with-bookmark-test-list): New macro environment to test a list of
  >       bookmarks.
  >       (with-bookmark-test-file-list): New macro environment to test a list
  >       of bookmarks with example.txt.
  >       (with-bookmark-bmenu-test-list): New macro environment to test
  >       functions about a list of bookmarks from `bookmark-bmenu-list'.
  >       (bookmark-tests-all-names-list, bookmark-tests-get-bookmark-list,
  >       bookmark-tests-get-bookmark-record-list): New functions to test the
  >       records of the list of bookmarks.
  >       (bookmark-tests-make-record-list): New function to test the creation
  >       of a record from example.txt with a list of bookmarks loaded.
  >       (bookmark-tests-delete-all): New function to test
  >       `bookmark-delete-all'.
  >       (bookmark-test-bmenu-any-marks-list): New function to test
  >       `bookmark-bmenu-any-marks' with a list of bookmarks.
  >       (bookmark-test-bmenu-mark-all): New function to test
  >       `bookmark-bmenu-mark-all'.
  >       (bookmark-test-bmenu-unmark-all): New function to test
  >       `bookmark-bmenu-unmark-all'.
  >       (bookmark-test-bmenu-delete-all): New function to test
  >       `bookmark-bmenu-delete-all'.
  > 
  > M   lisp/bookmark.el
  > A   test/lisp/bookmark-resources/test-list.bmk
  > M   test/lisp/bookmark-tests.el
  > 
  > commit eb9e065c00c5590967255fa3abf51db966a5df72
  > Author:     Juri Linkov <juri@linkov.net>
  > AuthorDate: Wed Jul 29 03:47:29 2020 +0300
  > Commit:     Juri Linkov <juri@linkov.net>
  > CommitDate: Wed Jul 29 03:47:29 2020 +0300
  > 
  >     * lisp/vc/vc-git.el (vc-git-log-view-mode): Font-lock AuthorDate 
(bug#40248)
  >     
  >     Highlight "AuthorDate" in log-view-font-lock-keywords
  >     when [format] pretty = fuller.
  > 
  > M   lisp/vc/vc-git.el

Attached is the full 'test/lisp/bookmark-tests.log' file after running 'make 
check'.

Best regards,
-Karl

bookmark-tests.log
Description: test/lisp/bookmark-tests.log (after 'make check' has completed)

signature.asc
Description: PGP signature