Re: NS port cleanups

[Po Lu]

Alan Third <alan@idiocy.org> writes:

> Looks better, thanks!

> I think I would prefer if you split this along the lines you outlined
> in the previous email. It's quite a large patch at the moment doing a
> number of apparently unrelated things.

Will do, thanks.  But it would be easier for me if you could review the
big patch first, and if it's all fine, I'll split it up.

> Can I ask why you're saving the context every time ns_focus is called?
> It shouldn't be necessary unless we're making a change, like calling
> NSRectClip. Any deeper functions that make changes save and restore
> the context locally.

That makes it easier to nest ns_focus.  (Unless that's a bad idea, I
think it should work.)

> Is this DPS clipping for font drawing?

Yes, on GNUstep DPS functions don't respect clipping set through NSRectClip.

> I didn't actually mean for you to get rid of the whole comment as
> apart from the first sentence it refers to the action that immediately
> follows. Or do you think it's redundant?

I think the entire comment is not accurate anymore; the precise
behaviour of redisplay seems to have changed.  But I'm not sure.

>>  
>> @@ -9867,7 +9873,11 @@ Convert an X font name (XLFD) to an NS font name.
>>  \n\
>>  Each SYMBOL is `control', `meta', `alt', `super', `hyper' or `none'.\n\
>>  If `none', the key is ignored by Emacs and retains its standard meaning.");
>> +#ifdef NS_IMPL_GNUSTEP
>> +  ns_alternate_modifier = Qalt;
>> +#else
>>    ns_alternate_modifier = Qmeta;
>> +#endif
>>  
>>    DEFVAR_LISP ("ns-right-alternate-modifier", ns_right_alternate_modifier,
>>                 "This variable describes the behavior of the right alternate 
>> or option key.\n\
>> @@ -9888,7 +9898,11 @@ Convert an X font name (XLFD) to an NS font name.
>>  \n\
>>  Each SYMBOL is `control', `meta', `alt', `super', `hyper' or `none'.\n\
>>  If `none', the key is ignored by Emacs and retains its standard meaning.");
>> +#ifdef NS_IMPL_GNUSTEP
>> +  ns_command_modifier = Qmeta;
>> +#else
>>    ns_command_modifier = Qsuper;
>> +#endif

> We have command bound to super so the default Openstep shortcuts work,
> like cmd-q to quit, and alt bound to meta, because that's pretty
                          ^^^
> standard in Emacs.

What do you mean by "alt" here?  If it means the "alt" key on the user's
keyboard, then I think setting ns_command_modifier to meta is TRT,
because on most systems that will be the left alt key.

Thanks.