Re: master d7e848ccda 2/3: Use icons in outline

[Michael Heerdegen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> branch: master
> commit d7e848ccdaab81fed187b415e95c436b6deb2657
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>

> +(defcustom outline-minor-mode-use-buttons '(derived-mode . special-mode)
> +  "Whether to display clickable buttons on the headings.

>  (defvar outline-level #'outline-level
> @@ -434,7 +434,10 @@ outline font-lock faces to those of major mode."
>                           (goto-char (match-beginning 0))
>                           (not (get-text-property (point) 'face))))
>              (overlay-put overlay 'face (outline-font-lock-face)))
> -          (when outline-minor-mode-use-buttons
> +          (when (and outline-minor-mode-use-buttons
> +                     (or (eq outline-minor-mode-use-buttons t)
> +                         (buffer-match-p outline-minor-mode-use-buttons
> +                                         (current-buffer))))

Lars, this has an unintended effect for me: If I ediff buffers with
outline-minor-mode turned on, and do

#+begin_src emacs-lisp
(add-hook 'ediff-prepare-buffer-hook
          (defun test ()
            (when (bound-and-true-p outline-minor-mode)
              (outline-show-all))))
#+end_src

then the ediffed buffers will get buttons.  Worse: they stay even after
finishing Ediff.  Tested with emacs -Q.

Seems that when `ediff-prepare-buffer-hook' is run the buffers are in a
temporary state where the (derived-mode . special-mode) condition is
fulfilled, or something like that.


TIA,

Michael.