emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is it valid to call isearch-filter-predicate outside isearch?


From: Ihor Radchenko
Subject: Re: Is it valid to call isearch-filter-predicate outside isearch?
Date: Thu, 01 Jun 2023 11:44:16 +0000

Juri Linkov <juri@linkov.net> writes:

>> Org produces its own side effects to make isearch
>> support revealing text hidden via text properties.
>
> When your isearch-filter-predicate can't be improved to be
> usable also during query-replace, then probably you need to
> set isearch-filter-predicate in isearch-mode-hook, and remove
> afterwards in isearch-mode-end-hook.

Good point. Although I want things to work in query-replace as well.

>> It would be nice if the docstring of `isearch-filter-predicate'
>> mentioned that it might be called outside isearch-mode.
>
> isearch.el is both a core library and UI with the search commands.
> UI commands for isearch-mode are enabled by C-s, etc.
> But as a core library its functions including isearch-filter-predicate
> are used by other packages such as replace.el.

Which is not documented. I am asking this fact to be documented.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]