Re: Is it valid to call isearch-filter-predicate outside isearch?

[Michael Heerdegen]

Ihor Radchenko <yantar92@posteo.net> writes:

> > If it does, maybe using `post-command-hook' would be a better choice
> > than `isearch-end-hook' (which is, obviously, not a good choice)?
>
> Surely not. `post-command-hook' is triggered after each
> `self-insert-command' during isearch/query-replace.

Of course the idea is not to so something blindly.  One could check
whether isearch is still active and which overlays need to be kept.

> I had to advice `isearch-clean-overlays', which appears to be called by
> all the users of `isearch-filter-predicate' (replace-regexp, evil-mode,
> and swipet). Still a workaround. Ugly.

Hmm.  Maybe the optimum.

BTW, did you consider to :before advice the local variable
`isearch-filter-predicate' instead of overwriting it?  That would be a
bit nicer for users and other modes that also need to change it.


Michael.