Re: Is this proper time format?

[David Masterson]

Ihor Radchenko <yantar92@posteo.net> writes:

> In message-mode:
>
> C-c C-a runs the command mml-attach-file (found in message-mode-map),
> which is an autoloaded interactive native-compiled Lisp function in
> ‘mml.el’.

I used C-c C-a to attach my patch to the message for you.  I was looking
for the reverse to pull your patch out.  When I read the message, the
patch was inlined, so I wasn't seeing any buttons(?) to pull it out with
and the Mime command didn't seem to do anything, so I thought I was
looking in the wrong.  The patch showed in diff-mode.

> I left the incorrectly spelled 'timerange' cindex entry on purpose.
> In Org, we have variables `org-agenda-timerange-leaders' and
> `org-agenda-remove-timeranges-from-blocks'. So, in Info-mode, some
> people may search index for 'timerange' instead of 'time range'. Again,
> the purpose is helping searchability.
>
> I now applied to patch onto main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d50956e48

Thank you.

> Not exactly. There is git command to find total number of changed LOCs:
>
> <https://github.com/yantar92/emacs-config/blob/master/config.org#detect-fsf-contribution-status-of-sender-for-org-ml>
> (shell-command-to-string
>                (format "cd ~/Git/org-mode/; git log --author=\"%s\" 
> --pretty=tformat: --numstat main | gawk '{ add += $1; subs += $2; loc += $1 - 
> $2 } END { printf \"+l: %%s -l: %%s total: %%s\", add, subs, loc }' -"
>                        (downcase (if (string-match-p email all-committers)
>                                      email sender))))

Whoa.

> However, it will count all the LOCs, not just non-trivial.
> By raw number of LOCs, your patch is indeed over 15LOC. However, part of
> the patch is my text or syncing org-manual and org-guide texts. Those
> changes are trivial.
>
> So, I judged that the patch is still acceptable without FSF assignment.
> But it will be the limit.

Understood.

-- 
David Masterson