emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region


From: Fran Burstall
Subject: Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region
Date: Tue, 25 Sep 2018 19:30:53 +0100



On Tue, 25 Sep 2018 at 18:52, Yoni Rabkin <address@hidden> wrote:

>
> My preference for emms-playlist-limit would be:
>
> 1.  Limit the playlist buffer it is called from (and error out if it
> is called from a non-playlist buffer).
>
> 2.  If the calling buffer is the current playlist, make the limited
> playlist current, otherwise not.

I agree with the above.

> 3.  Have a variable emms-playlist-limit-only-current so that users
> can get the old behaviour back if they want it.

Won't hurt to have; not a big deal to omit.

This should all be easy to implement after the rewrite of emms-playlist-limit.  I will do so and push to the emms-playlist-limit branch when done.
 
> Similar remarks apply to emms-playlist-save and, indeed, all other
> commands in the emms-playlist-mode-map: it violates the Principle of
> Least Surprise when they act on another, possibly invisible, buffer. 
> (That said, most commands in the mode-map do apply to the calling
> playlist but the limit fns and save are definite exceptions!).   If
> emms-playlist-save saved the calling buffer, this would go a long way
> towards making emms a comfortable environment for _editing_ playlists
> (which is one of the reasons I was attracted to emms in the first
> place) as well as playing them.  Thoughts?
>
> ---Fran

We should modify this behavior where we find it so that Emms conforms
with the rest of Emacs; when I hit C-x C-s it saves the buffer I'm
looking at, and not some invisible buffer.

I've added this to my general TODO.

I will also have a look at this...

---Fran

reply via email to

[Prev in Thread] Current Thread [Next in Thread]