Re: Automake!

[Pawel Kot]

Hi,

I've got few questions/comments.

On Nov 29, 2007 5:18 PM, Bastien Nocera <address@hidden> wrote:
> A big patch to automake gnokii. It adds a (maintainer-only) dependency

maintainer-only == for those who build from CVS, right?

> on glib-gettextize, and requires a libc with libintl (I don't think this
> would cause any problems, even under MSVC).

What about solaris/*bsd/mac osx?

+if GLIB
+# FIXME
+#SUBDIRS += smsd
+endif

Perhaps not autodetect but with explicit --enable-smsd option?

-autopoint -f

Why?

-dnl  Copyright (C) 1999 Hugh Blemings & Pavel Jan?k ml.
-dnl                2000 Karel Zak, Pawe? Kot
+dnl  Copyright (C) 1999 Hugh Blemings & Pavel Jan?k ml.
+dnl                2000 Karel Zak, Pawe? Kot

These are probably encoding issues. I'd like to keep everything utf-8.

+AC_INIT([gnokii],
+        [0.6.22],

Would it be possible to read from VERSION?

+AM_INIT_AUTOMAKE([1.9 dist-bzip2 no-dist-gzip])

I'd like to have dist-gzip as well.

-AC_CONFIG_HEADER(include/config.h)
+AC_CONFIG_HEADERS([include/config.h])

Not that it matters much, but why?

+    smsd support:       $found_glib
More logical would be using $have_smsd or something.

--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ common/localcharset.c       29 Nov 2007 16:00:10 -0000

What is that?

-bool GTerminateThread;
+extern bool GTerminateThread;

I don't think so.

-bool GTerminateThread;
+extern bool GTerminateThread = false;

Ditto.

-bool GTerminateThread = false;
+extern bool GTerminateThread;

Ditto.

And no, I haven't tried it yet. :)

take care,
pkot
-- 
Pawel Kot