Re: Automake!

[Pawel Kot]

Hi,

On Nov 29, 2007 8:45 PM, Bastien Nocera <address@hidden> wrote:
> > +AC_INIT([gnokii],
> > +      [0.6.22],
> >
> > Would it be possible to read from VERSION?
>
> Right now you change VERSION by hand for CVS/release versions. I think
> it would be easier to have one version in configure.in (changing
> depending on whether the configure is being run from CVS or not), and
> the config.h with the VERSION defined, rather than rely on an external
> file.
>
> When the VERSION file is modified, configure needs to be re-run to
> update the config.h, so you might as well do away with the separate
> VERSION file (we should also move the libtool versioning to configure as
> well).

So using this thing we can get rid of VERSION, right?

> > +AM_INIT_AUTOMAKE([1.9 dist-bzip2 no-dist-gzip])
> >
> > I'd like to have dist-gzip as well.
>
> I can make it spit out both, although usually bzip2 are generated by
> make dist, and then the gzip one is generated by whatever release
> scripts.

BTW. Please also look at packaging/make_dist to see what I do right
now to prepare the tarballs. There are few more things.

> > -bool GTerminateThread;
> > +extern bool GTerminateThread;
> >
> > I don't think so.
> >
> > -bool GTerminateThread;
> > +extern bool GTerminateThread = false;
> >
> > Ditto.
> >
> > -bool GTerminateThread = false;
> > +extern bool GTerminateThread;
> >
> > Ditto.
>
> Actually, this is correct. You want the global living in the library,
> not in the program, otherwise you can end up with the global not being
> defined in the program, and it would fail to link...

But that's not library, that's program. That's gnokiid, xgnokii, smsd.

take care,
pkot
-- 
Pawel Kot