Re: Automake!

[Bastien Nocera]

On Fri, 2007-11-30 at 20:57 +0100, Pawel Kot wrote:
<snip>
> > I'm not sure what all the business with gnvcal.c is though. Is it
> > supposed to be built and shipped in the tarballs?
> 
> Yeah. To not require flex to be installed when someone wants to compile it.

That should be easy to fix actually, we just need to add it to
EXTRA_DIST.

<snip>
> > We put GTerminateThread in the library (libDATA.la), so that we don't
> > end up with a linker error when a program doesn't define
> > GTerminateThread. Seems quite straight forward to me.
> 
> Yeah. But it is required for the program to define it. Still as
> libDATA is local to gnokii (it is not linked to libgnokii), it's not
> much a problem.
> 
> And virtmodem.c defines it as extern, so if you don't modify that,
> build will fail.

The fix I put in puts it as a local variable in virtmodem.c.

I'll see how it works once the rest of the patch is commited.

Cheers