gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GDL2 EOFault.m patch to fix -[EOFault forward::] on MacOS 10.4


From: David Ayers
Subject: Re: GDL2 EOFault.m patch to fix -[EOFault forward::] on MacOS 10.4
Date: Thu, 06 Mar 2008 14:39:13 +0100
User-agent: Mozilla-Thunderbird 2.0.0.9 (X11/20080110)

Hello Tim!

Tim McIntosh schrieb:

> Is this patch too evil, or can we do something like this?

Hehe... actually, it's not evil enough. ;-)

I've committed a patch that should replace the runtime implementation
pointer of EOFault's forward:: method with the one of NSObject.  This
should also save us a level of indirection at the price of not being
able to set a breakpoint in gdb for EOFault'S forward::.

For gnu-gnu-gnu (i.e. the GNU runtime) forward:: is actually not called
anymore so I can't really test it.  Could you please let me know if this
works for you?

> It allows -[EOFault forward::] to work on MacOS 10.4, gets rid of some code 
> duplicated from NSObject.m,  and allows the following unimplemented methods 
> to 
> be deleted from GSCategories.h and GSCompatibility.m in base:
> 
>     // Used only in EOFault.m, -[EOFault forward::], for Object compatibility
>     @interface NSInvocation(GSCompatibility)
>     - (retval_t) returnFrame:(arglist_t)args;
>     - (id) initWithArgframe:(arglist_t)args selector:(SEL)selector;
>     @end
> 

Indeed, if this works (and if that was really the last place these
methods were used) then I'm fine with having this removed from -base.

Cheers,
David




reply via email to

[Prev in Thread] Current Thread [Next in Thread]