Re: [Gnustep-cvs] r28488 - /libs/gui/branches/testplant_1/

[Gregory Casamento]

Fred,

On Fri, Aug 21, 2009 at 3:57 PM, Fred Kiefer<address@hidden> wrote:
> Gregory Casamento schrieb:
>> I've been taking selected fixes, currently only the deadlock fixes
>> from NSUserDefaults.
>
> Great.
>
>> I'd appreciate any detailed feedback you have on the others before
>> inclusion into the trunk.
>
> Patches that look ok to me:
>
> 28492 GSLayoutManager.m
>

Okay, I'll go ahead and pull this one into the trunk.

> Patches that will need a bit more explanation/rework:
>
> 28498 NSOpenPanel.m
> Why not change the method _shouldShowExtension: or what is the difference?

I'll forward this concern.

> 28494 NSFont.m
> The user default is fine, but will need documentation too.

Okay.

>> With respect to the GSContext change, it has helped prevent some
>> issues with multi-threaded apps in GUI.  I would like to make it less
>> coarse grained so that it can be brought to the trunk as well.
>
> As I already explained: This change is working around the problem that
> we use the same graphic context for a window in different threads. What
> we should do is create a specific context for each thread.

Yes, I agree. Ideally I would like to make it per window identifier/device.

GC

-- 
Gregory Casamento
Open Logic Corporation, Principal Consultant
## GNUstep Chief Maintainer
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell), (301)362-9640 (Home)