Re: Compiler warnings with the new base code

[Fred Kiefer]

Things are worse than I expected. I just ran the test suite for base and
got plenty of FAILs from it:

--- Running tests in base ---

base/coding/basictypes.m:
FAIL: base/coding/basictypes.m

base/coding/decoding.m:
FAIL: decoding version 2 of class NSValue

base/Functions/NSGeometry1.m:
FAIL: near identical points are equal
FAIL: near identical sizes are equal
FAIL: near identical rects are equal

base/GSMime/general.m:
FAIL: base/GSMime/general.m

base/KVC/mutable.m:
ofObject:<Lists: 0x6856a0>
context:(null)
ofObject:<Lists: 0x6856a0>
context:(null)
ofObject:<Lists: 0x6856a0>
context:(null)
ofObject:<Lists: 0x6856a0>
context:(null)
ofObject:<Lists: 0x6856a0>
context:(null)
ofObject:<Lists: 0x6856a0>
context:(null)
ofObject:<Lists: 0x6856a0>
context:(null)

base/NSException/basic.m:
FAIL: raises exception in description
FAIL: working callStackSymbols
: Uncaught exception NSGenericException, reason: Terminate
FAIL: base/NSException/basic.m

base/NSKeyedArchiver/basic.m:
FAIL: raises exception in description
FAIL: raises exception in description

base/NSLock/doubleLocking.m:
FAIL: Recursive lock with NSLock deadlocks ... this is not a real test,
just a reminder that recursively locking should deadlock the thread
after printing a diagnostic message
FAIL: Recursive lock with NSConditionLock deadlocks ... this is not a
real test, just a reminder that recursively locking should deadlock the
thread after printing a diagnostic message

base/NSMutableString/NSMutableString_string.m:
FAIL: base/NSMutableString/NSMutableString_string.m

base/NSNumber/basic.m:
FAIL: Object 0 of class 'NSNumber' is retained by copy with other zone

base/NSNumberFormatter/basic.m:
FAIL: base/NSNumberFormatter/basic.m

base/NSProxy/test01.m:
FAIL: Proxy NSPoint

base/NSStream/socket.m:
FAIL: base/NSStream/socket.m

base/NSString/NSString_base.m:
FAIL: base/NSString/NSString_base.m

      1
    252 COMPLETED
      7 context
     19 FAIL
      7 ofObject
   5124 PASS


Looking into the first one shows that the test that is failing was this
code:
obj1 = [Model new];
  data = [NSArchiver archivedDataWithRootObject: obj1];
  obj2 = [NSUnarchiver unarchiveObjectWithData: data];
  pass([obj1 testCInt:obj2],       "archiving as int - dearchiving as
NSInteger");
  pass([obj1 testCUInt:obj2],      "archiving as unsigned int -
dearchiving as NSUInteger");
  pass([obj1 testNSInteger:obj2],  "archiving as NSInteger - dearchiving
as int");
  pass([obj1 testNSUInteger:obj2], "archiving as NSUInteger -
dearchiving as unsigned int");