gnustep-make problem with tools and resource bundles Re: Next release?

[Sebastian Reitenbach]

Ping!
 
On Thursday, December 12, 2013 07:23 CET, "Sebastian Reitenbach" 
<address@hidden> wrote: 
 
>  
> On Monday, December 9, 2013 23:00 CET, Fred Kiefer <address@hidden> wrote: 
>  
> > I would like to suggest to have a shared release of the GNUstep core
> > components before the end of this year.
> 
> This is great, and I'm all for it.
> 
> > There was a base release a few months ago, but the last gui/back release
> > was more than six months ago. And right after that release I fixed a bug
> > in gui that will show up with all newer Linux systems.
> > 
> > It would be great, if many different people could test the SVN code on a
> > lot of different systems. At the moment I am myself testing the current
> > GNUstep code on OpenSuse 13.1. There the copy/paste mechanism seems to
> > be broken. When calling copy from the menu I get the following stack dump:
> > 
> 
>  
> I have a problem with GNUstep make. With the ImpersonatorToolKit, I have
> a Tool with additional Resource files that need to get installed. So I have
> them in the Resources subdirectory, and in GNUmakefile I have set:
> 
> ImpersonatorToolKit_HAS_RESOURCE_BUNDLE=yes 
> 
> then
> make && make install
>  works well and as expected, but trying to do:
> make clean
> 
> completely wipes the Resources directory from the disk. This is only annoying
> when you have the stuff in SVN or elsewhere, but may wipe important stuff 
> before
> you have it in a RCS ;)
> 
> The patch below fixes the problem for me, only deleting the subdirectory
> that gets created when calling make .
> Before I came up with the patch as it is currently below, I stumbled about
> the GNUSTEP_SHARED_BUNDLE_RESOURCE_PATH variable that gets
> filled in Instance/tool.make, but trying to use that variable, its empty at
> the make clean stage, so didn't work.
> Is that patch the right approach to the problem? If so, I'd like to go on
> and commit it, otherwise I'm open for other suggestions.
> 
> 
> 
> cheers,
> Sebastian
> 
> 
>  
>  $OpenBSD$
> --- Master/tool.make.orig     Wed Dec 11 07:24:02 2013
> +++ Master/tool.make  Wed Dec 11 07:25:46 2013
> @@ -41,7 +41,7 @@ $(GNUSTEP_BUILD_DIR)/Resources:
>  # On distclean, we want to efficiently wipe out the Resources/
>  # directory.
>  internal-clean::
> -     rm -rf $(GNUSTEP_BUILD_DIR)/Resources
> +     rm -rf $(MAYBE_GNUSTEP_BUILD_DIR_RESOURCES)/$(TOOL_NAME)
>  else
>  MAYBE_GNUSTEP_BUILD_DIR_RESOURCES =
>  endif
> 
> 
> 
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnustep-dev