[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GWorkspace startup - Setting unknown econding
From: |
Fred Kiefer |
Subject: |
Re: GWorkspace startup - Setting unknown econding |
Date: |
Sat, 30 May 2020 00:19:47 +0200 |
> Am 29.05.2020 um 21:13 schrieb Riccardo Mottola <riccardo.mottola@libero.it>:
>
> Hi Fred,
>
>
> Fred Kiefer wrote:
>> Turns out I was wrong here. Of course the bison grammar was wrong and needed
>> correction, but this was not what caused this issue. Here 10000 is a valid
>> code page that should be mapped to Mac Roman. The handing of many other code
>> pages is still missing as we don’t ave constants for these in base. This
>> specific one was important as it gets used a lot on the Mac.
>> Please give the new code a try,
>
>
> Great work - GWorkspace now loads without errors again.
> Since I presume it was caused by loading some of its Help files... I tried
> opening them with Ink without issues.
>
> I wonder, those files were not touched since a long time....
This is easy to explain. Before my last change to the RTF parsing the code page
instructions where ignored by the parser. Now they get handled and if the
encoding is unknown a warning is shown. In the future there will be more cases
where the encoding isn’t handled correctly and the code will tell us about
that. Previously we just used the wrong encoding and displayed some characters
incorrectly.