Re: [PATCH] biosdisk / open_device() messing up offsets

[Bean]

On Sun, Jun 8, 2008 at 3:29 PM, Pavel Roskin <address@hidden> wrote:
>> btw, please try the patch, it dumps the journal information. There
>> could be quite some output, you can use grub-fstest to capture it.
>
> It breaks installation:
>
> # grub-install /dev/sda
> grub-mkimage: error: cannot stat /usr/local/lib/grub/i386-pc/header:.mod
>
> "header:" must be from the patch.
>
> I cannot generate a short image easily because loopback devices are not
> supported.  Perhaps I'll try making a real partition initialized with
> zeroes or something like that.

Can you use grub-fstest ?

Also, the header is from

+  grub_printf ("header: %d %d %d\n", log->first_block,
log->last_block, log->start_block);

I don't know why the number doesn't show, unless log is invalid
pointer. Perhaps the size is invalid, try to add a debug line to show
the allocated size of log:

  log = grub_malloc (sizeof (struct grub_fshelp_journal) +
                     grub_be_to_cpu32 (jsb->maxlen) * sizeof
(grub_disk_addr_t));




-- 
Bean