Re: [PATCH] biosdisk / open_device() messing up offsets

[Pavel Roskin]

Quoting Robert Millan <address@hidden>:

> If not, then we'd have
> to figure out why sector 0 of the partition can be accessed directly via
> hexdump.

As I understand, "(hd0,1)" doesn't refer to an extent of data, i.e. it  
not a file or a block list that can be opened like a file.   
"(hd0,1)+1" is the first sector of the partition.  But "(hd0,1)" is  
not all sectors of the partition.  It the partition name.  It can be  
used in the "ls" command, whereas "(hd0,1)+1" cannot.

> > By the way, the current GRUB just failed to install on my test system.
> > After I rebooted it, GRUB hung on startup after showing "GRUB".
>
> Please run a regression test, if you can.

The installation was broken by that patch, so I reverted it.  It's  
easy to check the installation by doing it on a mounted flash drive,  
so that the real boot device is not at risk.

--
Regards,
Pavel Roskin