Re: [PATCH] biosdisk / open_device() messing up offsets

[Pavel Roskin]

Quoting Robert Millan <address@hidden>:

> On Fri, Jun 06, 2008 at 06:53:52PM -0400, Pavel Roskin wrote:
> > On Fri, 2008-06-06 at 17:56 +0200, Robert Millan wrote:
> > > Committed.
> >
> > I believe it's wrong.
>
> You mean that the lines I removed were wrong, or that my commit is wrong?

The commit is wrong.

> I thought you agreed that those lines were bogus.

No, I explained why they were needed.  Sorry, I must have been unclear.

> If not, then we'd have
> to figure out why sector 0 of the partition can be accessed directly via
> hexdump.

Absolutely.

> > By the way, the current GRUB just failed to install on my test system.
> > After I rebooted it, GRUB hung on startup after showing "GRUB".
>
> Please run a regression test, if you can.

I could boot from the rescue CD, so it's not that bad.

I'm looking at the problem now.

--
Regards,
Pavel Roskin