Re: [PATCH] Misc patches for grub2

[Pavel Roskin]

On Sun, 2008-07-27 at 14:00 +0800, Bean wrote:
> Hi,
> 
> On Sun, Jul 27, 2008 at 12:55 PM, Pavel Roskin <address@hidden> wrote:
> > Our main repository is in Subversion, so whoever applies the patch
> > should use "svn move" to keep the contiguous file history.  Unlike git,
> > which trusts the contents in the first place, Subversion is more
> > sensitive to whatever users are telling it.
> 
> I use git-mv to move files, which is the equivalence of "svn move".
> But when I use git-diff to generate the patch, it looks as if files
> are truncated. I can use git-diff -M to create a patch that shows the
> renames, but it's not usable by patch.

That's why I'm asking "whoever applies the patch" to be careful.

> > IMHO that even worse.  Using a trademarked name like "linux" to run the
> > trademarked software could be justified.  But using a trademarked name
> > to replace or emulate the original software is asking for a big trouble.
> >
> > Admittedly, I'm not a lawyer, but some people are, and it's better not
> > to attract their attention.
> 
> In fact, it doesn't replace bootcamp, it calls the service provided by
> bootcamp. But anyway, it's not a big deal, I can just keep the name
> appleloader.

Fine.

> BTW, any comment about the other changes ?

Why do we need "crc"?  If there are chances that it will be used for
security, we should be using SHA-1.

-- 
Regards,
Pavel Roskin