Re: [PATCH] Misc patches for grub2

[Pavel Roskin]

On Sun, 2008-07-27 at 15:30 +0800, Bean wrote:
> On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin <address@hidden> wrote:
> >> >> BTW, any comment about the other changes ?
> >> >
> >> > Why do we need "crc"?  If there are chances that it will be used for
> >> > security, we should be using SHA-1.
> >>
> >> crc is useful in many place. For example, png, jffs2, etc.
> >
> > But why make it a command?
> 
> There are two parts, one is lib/crc.c, which contains only the crc
> function, the other is command/crc.c, which is a command to calculate
> the crc of selected file. Although it's not necessary to have a
> command, but it can 1) serve as an example of how to use the crc
> function, 2) as a cheap way to verify if a file is read correctly by
> the fs driver.

OK, then it's probably a good idea.

-- 
Regards,
Pavel Roskin