[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add gctp
From: |
Leo Famulari |
Subject: |
Re: [PATCH] Add gctp |
Date: |
Fri, 23 Sep 2016 21:08:25 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Thu, Sep 15, 2016 at 07:08:08PM +0200, Thomas Danckaert wrote:
> Hi Guix,
>
> I've cleaned up my gctp patch, following your advice:
>
> From: Leo Famulari <address@hidden>
> Subject: Re: [PATCH] Add gctp
> Date: Mon, 18 Jul 2016 17:47:23 -0400
>
> > If it's not possible to use the bundled GCTPs then we have to use an
> > external library, but I think it should be maintained outside of Guix.
> > As you say, it should not be much work to put it on a public Git repo or
> > to host a tarball, since the development is basically complete.
>
> I took the contents of the gctpc20.tar.Z archive distributed with wgrib2,
> added an autoconf-based build script, and published the repository on
> Github. Changes are minor: I had to make some changes to the test programs,
> and fix one input routine (int size mismatch when reading an auxiliary
> binary file).
>
> This version of the patch uses a release tarball published on github. Is
> there a better place I can host a tarball (if not the repository itself?).
Wow, thank you! A GitHub tarball is fine if it works (and this one
does).
> + (version "2.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
The only thing I would like to change is this mismatch between the
version and the tarball name. Can we call it version 2.0.0?
Also, we should add a (file-name) field so that the downloaded tarball
has "gctp" in the name.
I can make these changes locally if you think they are okay.