[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add gctp
From: |
Thomas Danckaert |
Subject: |
Re: [PATCH] Add gctp |
Date: |
Sat, 24 Sep 2016 21:49:56 +0200 (CEST) |
From: Leo Famulari <address@hidden>
Subject: Re: [PATCH] Add gctp
Date: Fri, 23 Sep 2016 21:08:25 -0400
>> + (version "2.0")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
>
> The only thing I would like to change is this mismatch between the
> version and the tarball name. Can we call it version 2.0.0?
>
> Also, we should add a (file-name) field so that the downloaded tarball
> has "gctp" in the name.
>
> I can make these changes locally if you think they are okay.
Of course, go ahead!
Thanks for reviewing the patch(-es).
Thomas