[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add gctp
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH] Add gctp |
|
Date: |
Tue, 27 Sep 2016 13:38:08 -0400 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Sat, Sep 24, 2016 at 09:49:56PM +0200, Thomas Danckaert wrote:
> From: Leo Famulari <address@hidden>
> Subject: Re: [PATCH] Add gctp
> Date: Fri, 23 Sep 2016 21:08:25 -0400
>
> >> + (version "2.0")
> >> + (source
> >> + (origin
> >> + (method url-fetch)
> >> + (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz";)
> >
> > The only thing I would like to change is this mismatch between the
> > version and the tarball name. Can we call it version 2.0.0?
> >
> > Also, we should add a (file-name) field so that the downloaded tarball
> > has "gctp" in the name.
> >
> > I can make these changes locally if you think they are okay.
>
> Of course, go ahead!
>
> Thanks for reviewing the patch(-es).
Great, pushed as 32f70e1f86141ed30f1026ea0cf8a4bd377004b0 !
>
> Thomas