[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66436] [PATCH v2] doc: Add some guidelines for reviewing.
From: |
Simon Tournier |
Subject: |
[bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. |
Date: |
Tue, 24 Oct 2023 10:59:45 +0200 |
Re,
On Tue, 24 Oct 2023 at 10:49, Simon Tournier <zimon.toutoune@gmail.com> wrote:
>> --8<---------------cut here---------------start------------->8---
>> +Perhaps the biggest action you can do to help GNU Guix grow as a project
>> +is to review the work contributed by others. You do not need to be a
>> +committer to do so; applying, reading the source, building, linting and
>> +running other people's series and sharing your comments about your
>> +experience will give some confidence to committers, and should result in
>> +the proposed change being merged faster.
>> --8<---------------cut here---------------end--------------->8---
[...]
> IMHO, it is worth to clearly state:
>
> 1. what helps the review process:
>
> « applying, reading the source, building, linting and running other
> people's series and sharing your comments about your experience will
> give some confidence to committers, and should result in the
> proposed change being merged faster. »
Although I do not know if it is the right place, I would mention that
“building” also means that the dependants still build or clearly
indicate if something breaks.
Cheers,
simon
- [bug#66436] [PATCH] doc: Add some guidelines for reviewing., (continued)
- [bug#66436] [PATCH] doc: Add some guidelines for reviewing., Ludovic Courtès, 2023/10/10
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Maxim Cournoyer, 2023/10/10
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Clément Lassieur, 2023/10/20
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Simon Tournier, 2023/10/24
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing.,
Simon Tournier <=
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Maxim Cournoyer, 2023/10/31
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Simon Tournier, 2023/10/31
[bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Ludovic Courtès, 2023/10/24
[bug#66436] [PATCH 0/2] Add support for Git Large File Storage (LFS)., Maxim Cournoyer, 2023/10/11