[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66436] [PATCH v2] doc: Add some guidelines for reviewing.
From: |
Simon Tournier |
Subject: |
[bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. |
Date: |
Tue, 31 Oct 2023 20:03:47 +0100 |
Hi Maxim,
On Tue, 31 Oct 2023 at 19:53, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> >> IMHO, it is worth to clearly state:
[...]
> That's already mentioned in 'Submitting Patches':
[...]
> I don't think we should repeat it here :-) (also, we now have CI, which
> should be more apt at catching breakage here).
We are listing the expectations for the Review process, therefore
repeat that the dependencies need to be checked at Review time makes
sense to me. It can be a sentence as: "make sure CI does not report
new error" or something like that.
Cheers,
simon
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., (continued)
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Clément Lassieur, 2023/10/20
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Simon Tournier, 2023/10/24
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Simon Tournier, 2023/10/24
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Maxim Cournoyer, 2023/10/31
- [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing.,
Simon Tournier <=
[bug#66436] [PATCH v2] doc: Add some guidelines for reviewing., Ludovic Courtès, 2023/10/24
[bug#66436] [PATCH 0/2] Add support for Git Large File Storage (LFS)., Maxim Cournoyer, 2023/10/11