Re: image-dired shows images as text

[Allan]

Nick Roberts <nickrob@snap.net.nz> writes:

> I've checked the change below into CVS.  If Emacs can't find convert it should
> now say so with this patch.  Can you please try to apply it and then post what
> Emacs says to the mailing list.
>
> -- 
> Nick                                           http://www.inet.net.nz/~nickrob
>
>
> *** thumbs.el.~1.35.~ 2007-07-27 09:22:25.000000000 +1200
> --- thumbs.el 2007-12-28 21:01:18.000000000 +1300
> *************** ARG any arguments to the ACTION command,
> *** 248,262 ****
>   OUTPUT-FORMAT is the file format to output (default is jpeg),
>   ACTION-PREFIX is the symbol to place before the ACTION command
>                 (defaults to '-' but can sometimes be '+')."
> !   (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\""
> !                      thumbs-conversion-program
> !                      (or action-prefix "-")
> !                      action
> !                      (or arg "")
> !                      filein
> !                      (or output-format "jpeg")
> !                      fileout)))
> !     (call-process shell-file-name nil nil nil shell-command-switch 
> command)))
>   
>   (defun thumbs-new-image-size (s increment)
>     "New image (a cons of width x height)."
> --- 248,259 ----
>   OUTPUT-FORMAT is the file format to output (default is jpeg),
>   ACTION-PREFIX is the symbol to place before the ACTION command
>                 (defaults to '-' but can sometimes be '+')."
> !   (call-process thumbs-conversion-program nil nil nil
> !             (or action-prefix "-")
> !             action
> !             (or arg "")
> !             filein
> !             (format "%s:%s" (or output-format "jpeg") fileout)))
>   
>   (defun thumbs-new-image-size (s increment)
>     "New image (a cons of width x height)."
I will try to apply the patch, but in the meantime I may have discovered some 
pertinent information. On Windows XP there is a DOS-style command called 
"convert" which can be accessed inside a command-prompt window. I wonder if 
there could be a conflict or confusion with this module?
  c:/WINDOWS/SYSTEM32:
  total used in directory 495476 available 13243296
  -rw-rw-rw-   1 XXXXXXX   root           333 2001-09-12  $ncsp$.inf
  -rw-rw-rw-   1 XXXXXXX   root           860 2002-01-27  $winnt$.inf
  drwxrwxrwx   1 XXXXXXX   root             0 12-28 07:32 .
  drwxrwxrwx   1 XXXXXXX   root             0 12-28 14:25 ..
....
  -rwxrwxrwx   1 XXXXXXX   root         13824 2001-08-18  convert.exe 
....
The way I found this out was that I tried the ImageMagick test in a command 
window : "convert logo: logo.gif" and got an error instead. When I navigated to 
the ImageMagick install directory using a DOS-style "cd" command it worked. If 
you append the ImageMagick directory to the end of the "PATH" environment 
variable the MS Windows "convert.exe" will be found first.

-- 
Allan