[Libcdio-devel] Unmerged branch ts-cdtext-fix

[Thomas Schmitt]

Hi,

one of the unclear branches seems not to have made it into "master":
  ts-cdtext-fix

I don't see traces of its commits (listed from oldest to newest):

  6347ef09b6d1a6211b93425bd9b12b9d92b34e8c
    Added comment to explain why function language_code_tests() exists

  bde2647b444136e2d23d303d0a02d27383fcea32 (by Rocky)
    Small typo caught by Thomas...
    ("Remove read-disc-struct binary" seems to have happened, though)

  dd44e33a2756cdf6780e5aaab1f42dbfc8b60da9
    Expanded maximum CD-TEXT payload size to 8 full text blocks of 256 * 18 
bytes

  53d38c7063c84c09c157441aad97934f603ef99f
    Applied the proper destructor to CdioDataSource_t if parse_cuefile() sees 
an undersized CDTEXTFILE

  60ec2678d8f51196f4ec1e793ce55f7f99be9e7d
    Enabled recognition and skipping of MMC headers before raw CD-TEXT data

  388e859770724155b13da7fbdce7bfbb65adb104
    Enabled recognition and skipping of MMC headers before CDTEXTFILE input in 
.CUE files

They look like they would provide improvements. But it's nearly five years
ago that i was aware why i proposed those changes.

What would be the best strategy to evaluate it ?

Up to now i only verified that it merges without complaints with a test
branch freshly made from "master".
Strangely, the two oldest commits
  bde2647b444136e2d23d303d0a02d27383fcea32
  6347ef09b6d1a6211b93425bd9b12b9d92b34e8c
were not applied by
  git merge 388e859770724155b13da7fbdce7bfbb65adb104
Both are mere comment corrections. Nevertheless i wonder what kept them
out.


Have a nice day :)

Thomas