lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes


From: lilypond
Subject: Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes
Date: Fri, 20 Jul 2012 06:16:12 +0000


Comment #38 on issue 2533 by address@hidden: Patch: line_count fixes
http://code.google.com/p/lilypond/issues/detail?id=2533

We have a problem with reviewing multiple-commit patches on Rietveld. One can upload them as twelve steps if wanted. Now the main point of having multiple commits is being able to bisect when problems occur, for better pinpointing of errors, and possibly reverting only parts. That means that this purpose is defeated if any commit in the series does not work on its own. For a series of twelve commits, doing a make check for every single commit is going to be painful unless you have a very powerful machine. You should at least check that make still goes through (when checking out one commit after the next, there will be very few changed files, so this is quite fast), and you might consider using git rebase -i for grouping the commits into a smaller number of logically and regtest-related commits larger than one but smaller than twelve. It would be good if you at least had one separate commit with the effects on slurs rather than just the effects on irregular staff spaces.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]