|
| From: | lilypond |
| Subject: | Replace deprecated functions from string module (issue 566920044 by address@hidden) |
| Date: | Wed, 23 Oct 2019 14:22:15 -0700 |
For someone who doesn’t know python two questions come up:
1. Why do you sometimes use " " and sometimes ' '?
2. Is a space (" " or ' ') the default for the old string.join? Or
should you use an empty string ("".join()) instead in some places of the
new version?
https://codereview.appspot.com/566920044/diff/549120043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/566920044/diff/549120043/python/musicexp.py#newcode694
python/musicexp.py:694: % " ".join (map (lambda x: x.lisp_expression(),
Here you use " " …
https://codereview.appspot.com/566920044/diff/549120043/python/musicexp.py#newcode1040
python/musicexp.py:1040: printer ('<%s>' % ' '.join (pitches))
… and here ' '.
https://codereview.appspot.com/566920044/
| [Prev in Thread] | Current Thread | [Next in Thread] |