lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 5628: fix warnings compiling flower unit tests (issue 54532004


From: lemzwerg
Subject: Re: Issue 5628: fix warnings compiling flower unit tests (issue 545320043 by address@hidden)
Date: Wed, 04 Dec 2019 22:49:33 -0800

LGTM


https://codereview.appspot.com/545320043/diff/581320043/flower/include/yaffut.hh
File flower/include/yaffut.hh (right):

https://codereview.appspot.com/545320043/diff/581320043/flower/include/yaffut.hh#newcode146
flower/include/yaffut.hh:146: // TODO: Once we are willing to require
C++11, use unique_ptr.
I think we *are* willing to do C++11, aren't we?

https://codereview.appspot.com/545320043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]