Re: Issue 5628: fix warnings compiling flower unit tests (issue 545320043 by address@hidden)

[jonas . hahnfeld]

On 2019/12/10 22:28:46, Dan Eble wrote:
> On 2019/12/10 21:28:14, hahnjo wrote:
> > Just curious, what would it take to just go to C++11 and unique_ptr?

> I don't know if the compiler that GUB uses properly supports C++11,
> and I'm not yet interested in spending my own time to investigate.

GUB builds GCC 4.9.4 which is fine for C++11. I'm not sure what the
cross-compiler for macOS supports (and I really dislike how GUB for
macOS blocks progress in a few important points...)

> I would fully support "someone" finding out which version of g++
> fully supports C++14 without any known issues, upgrading GUB
> to use it (if necessary), and then making it a requirement.

Is there a major benefit from using C++14? Not saying that I wouldn't be
in favor, but if we can get C++11 for free...

https://codereview.appspot.com/545320043/