[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden)
From: |
lemzwerg |
Subject: |
Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden) |
Date: |
Wed, 18 Dec 2019 10:02:33 -0800 |
LGTM, with some minor remarks.
https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely
File Documentation/notation/editorial.itely (right):
https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely#newcode496
Documentation/notation/editorial.itely:496: symbol in the form
@code{'@var{FooBar}} or a string in the form
If you use 'FooBar' as an example for an argument, it's better to *not*
use '@var'. If you want to use '@var', say
@code{'@var{color}}
to make 'color' a meta-variable and use @var{color} in the surrounding
text as a reference to it.
https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely#newcode579
Documentation/notation/editorial.itely:579: Not all colors are
distinguishable in a web browser, i.e. a web browser
There should always a comma after 'i.e.', as far as I know.
And please avoid lines longer than 80 characters.
https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):
https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/notation-appendices.itely#newcode863
Documentation/notation/notation-appendices.itely:863: Any name that is
spelled as a single word with capitalization (e.g.
AFAIK, there should always be a comma after 'e.g.'.
This is especially important for the PDFs since by default `texinfo.tex`
doesn't use frenchspacing, thus inserting a larger horizontal space
after a full stop.
https://codereview.appspot.com/551270043/
- Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden),
lemzwerg <=
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), rietveldpkx, 2019/12/19
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), lemzwerg, 2019/12/19
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), dak, 2019/12/19
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), rietveldpkx, 2019/12/21
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), lemzwerg, 2019/12/21
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), lemzwerg, 2019/12/21
- Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden), lemzwerg, 2019/12/21