Re: Doc: NR - Doc CSS colour support (issue 551270043 by address@hidden)

[rietveldpkx]

https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely
File Documentation/notation/editorial.itely (right):

https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely#newcode496
Documentation/notation/editorial.itely:496: symbol in the form
@code{'@var{FooBar}} or a string in the form
On 2019/12/18 18:02:33, lemzwerg wrote:
> If you use 'FooBar' as an example for an argument, it's better to
*not* use
> '@var'.  If you want to use '@var', say

>    @code{'@var{color}}

> to make 'color' a meta-variable and use @var{color} in the surrounding
text as a
> reference to it.

Thanks, that is better. Done.

https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely#newcode579
Documentation/notation/editorial.itely:579: Not all colors are
distinguishable in a web browser, i.e. a web browser
On 2019/12/18 18:02:33, lemzwerg wrote:
> There should always a comma after 'i.e.', as far as I know.


Nope. It's grammatical dogma (in the same vein as not starting sentences
with the words 'And' or 'Because). I think commas after these
abbreviations look ugly. It's not CG policy either - I checked - and, in
fact, the examples we give in CG 5.4.7 don't use commas either.

> And please avoid lines longer than 80 characters.
Thanks, fixed.

https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):

https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/notation-appendices.itely#newcode863
Documentation/notation/notation-appendices.itely:863: Any name that is
spelled as a single word with capitalization (e.g.
On 2019/12/18 18:02:33, lemzwerg wrote:
> AFAIK, there should always be a comma after 'e.g.'.

See my comment on the other file about this.

> This is especially important for the PDFs since by default
`texinfo.tex` doesn't
> use frenchspacing, thus inserting a larger horizontal space after a
full stop.

So? If it were that bad why are we using two spaces after a full point
then?

Which has nothing to do with grammar and would mean this would have to
be made policy (which it isn't) and fixed throughout the entire doc.

https://codereview.appspot.com/551270043/