Re: [Nufw-devel] auth_mysql patch

[Eric Leblond]

Hi,

Le mardi 25 septembre 2007 à 18:19 +0200, Francesco Varano a écrit :
> Hi to all,
>  as suggested by Eric i send to the developers mailing-list the patch
> for auth_mysql module with the modifications requested to me by Eric
> some days ago:
>  * option for the 'guest' group
>  * option to have fallback on guest or a direct DROP.
> 
> i've added also:
>  * option for the 'guest' user ID
>  * option for the 'guest' username

Really Fine. 

> Naturally every comment or suggestion is welcome.

-       return username ? username : g_strdup(IP_AUTH_IPAUTH_GUEST_USERNAME);
+       return (!username && params->fallback_to_guest) ? 
g_strdup(params->guest_username) : username;

Previous coding style was limit for me (but concise). The new line is
too difficult to read. I'd rather see an "if" usage there.

Could you resend it please ?

By the way, I've done backported the module from trunk to the 2.2 branch
and it will be available in the upcoming 2.2 release which will occur
after submitting your patch and doing some tests.

BR,
-- 
Eric Leblond <address@hidden>
INL

signature.asc
Description: Ceci est une partie de message numériquement signée