Re: [Nufw-devel] auth_mysql patch

[Francesco Varano]

Hi,

> 
> > Naturally every comment or suggestion is welcome.
> 
> -     return username ? username : g_strdup(IP_AUTH_IPAUTH_GUEST_USERNAME);
> +     return (!username && params->fallback_to_guest) ? 
> g_strdup(params->guest_username) : username;
> 
> Previous coding style was limit for me (but concise). The new line is
> too difficult to read. I'd rather see an "if" usage there.

ok, you're right i've been a victim of the dark side of the developer
one more time :-)

the attached patch should be much more readable.

Best Regards,
Francesco

P.S.
i cannot receive mails from nufw's mailing lists: i can see my previous
email only in the archives. I tried also changing email address, but no
"confirmation mail" arrived. Am i missing something?

auth_mysql.diff
Description: Text Data

signature.asc
Description: This is a digitally signed message part