Re: [Nufw-devel] auth_mysql patch

[Eric Leblond]

Hi,

Le mercredi 26 septembre 2007 à 10:49 +0200, Francesco Varano a écrit :
> Hi, 
> > > Naturally every comment or suggestion is welcome.
> > 
> > -   return username ? username : g_strdup(IP_AUTH_IPAUTH_GUEST_USERNAME);
> > +   return (!username && params->fallback_to_guest) ? 
> > g_strdup(params->guest_username) : username;
> > 
> > Previous coding style was limit for me (but concise). The new line is
> > too difficult to read. I'd rather see an "if" usage there.
> 
> ok, you're right i've been a victim of the dark side of the developer
> one more time :-)
> 
> the attached patch should be much more readable.

Applied, thanks Francesco.

BR,
-- 
Éric Leblond, address@hidden
Téléphone : 01 44 89 46 39, Fax : 01 44 89 45 01
INL, http://www.inl.fr

signature.asc
Description: Ceci est une partie de message numériquement signée