[Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry

[Nicholas Jankowski]

Follow-up Comment #15, bug #65421 (group octave):

after looking at the amount of input checking in __patch__.m I figured a
little bit more would at least put a bandaid on the main report issue. 
attached is a patch that slides any geometry related properties to the front
of the argument list before jumping into the compiled code.  also added a test
to patch.m that checks for the same output with cdata either before or after
faces.  seems to pass all simple tests with patch.  i haven't rebuild default
in a while, so rebuilding and running tests on there before pushing the patch.
 

note that in general, CData is meant to be used when you define your geometry
with xdata,ydata,zdata,  and FaceVertexCData is meant to be used when you
define your geometry with Faces / Vertices.  looking at how it changes some of
the 'other' properties when you mix them, it's not a great surprise that there
can be odd results.  could be that's causing the crashes you posted about. 

(file #55798)

    _______________________________________________________

Additional Item Attachment:

File name: bug65421_patchorderfix.diff    Size:2 KB
   
<https://file.savannah.gnu.org/file/bug65421_patchorderfix.diff?file_id=55798>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-04b18e1179b14c0ef710c8e9c8e59d1e4bcd7bd0.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65421>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/