[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #65421] patch fails to render if cdata is spec
From: |
Nicholas Jankowski |
Subject: |
[Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form |
Date: |
Fri, 15 Mar 2024 09:43:53 -0400 (EDT) |
Follow-up Comment #33, bug #65421 (group octave):
The ordering issue is definitely a problem buried in graphics.cc. With some
minimal testing on Matlab, property/value ordering seems to not matter at all
except for repeated properties (I think it retains the first instance of a
property, but haven't checked that in some time).
As `__patch__.m` was already doing quite a bit of input parsing and
reformatting before sending the argument list to `__go_patch__`, the initial
fix was definitely just an easy bandaid to try to sidestep the issue.
It would be fairly simple to turn the struct into name-value pairs, insert
them at the same position into the argument list, then perform the same hack
to avoid the bug. It would essentially avoid ever actually sending a struct to
`__go_patch__`. I don't know of anything user-visible that would be impacted
by that change, and it would sidestep the bug at the m-code level.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?65421>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry, (continued)
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry, Nicholas Jankowski, 2024/03/12
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry, Liang Tang, 2024/03/12
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry, Markus Mützel, 2024/03/12
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry, Liang Tang, 2024/03/12
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/12
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/12
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Markus Mützel, 2024/03/14
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/14
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/14
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Markus Mützel, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form,
Nicholas Jankowski <=
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Markus Mützel, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Markus Mützel, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Markus Mützel, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Nicholas Jankowski, 2024/03/15
- [Octave-bug-tracker] [bug #65421] patch fails to render if cdata is specified before geometry in property/value calling form, Markus Mützel, 2024/03/18