[Octave-patch-tracker] [patch #8140] Speed up importdata() ASCII CSV processing using dlmread() as core

[Erik Kjellson]

Follow-up Comment #1, patch #8140 (project octave):

Hello Dan,

Sorry about my late reply.

Nice performance improvement you've got there.
Here are my thoughts:

1. Column / Row header detection:
The detection of Column / Row headers is being done at line 296-301 in the
code (tip version, i.e. non-patched). It is simply comparing the dimensions of
the textdata cell array to the number of columns/rows. If you have exactly the
same number of data columns as there are words in the header (and using space
as delimiter) I think we have to assume that these are Column headers.

Wouldn't the header "TIME VOLTAGE DISPLACEMENT" in your example be interpreted
as column headers by Matlab? I think so.

2. Missing values
I think it makes sense as you said to put the empty string in the
output.textdata, but I think that Matlab is ignoring it since it's empty. I
don't have access to Matlab at the moment, so I cant check it right now.

3. CR for line breaks
I agree, sounds like the change (to accept r) should be made to dlmread ().

regards,
Erik

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8140>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/