[Octave-patch-tracker] [patch #8140] Speed up importdata() ASCII CSV processing using dlmread() as core

[Rik]

Update of patch #8140 (project octave):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #8:

Dan,

I applied your changset for importdata here
(http://hg.savannah.gnu.org/hgweb/octave/rev/44624eb20076) and then followed
it with another changset
(http://hg.savannah.gnu.org/hgweb/octave/rev/95412dcfa707).  The second
changeset overhauls the delimiter detection, speeds up the function by always
using dlmread even in the case of the space delimiter, and generally reduces
the length of the function.

One remaining issue is what to do about CSV files that are CR or CRLF
line-delimited.  We have %!tests for both of these cases, but I don't think
that is quite right.  The meaning of "\n" will change based on the platform
(UNIX, Windows, Mac).  If you are bringing a file from one platform to another
it is usually required that the user themselves convert the file before
further processing by using a utility such as dos2unix.  Unless we can prove
that Matlab is handling this case, I think this is the responsibility of the
user and we can delete these %!tests.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8140>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/