[Octave-patch-tracker] [patch #10016] [octave forge] (statistics) mhsample implementation (over from bug #59924)

[Philip Nienhuis]

Follow-up Comment #16, patch #10016 (project octave):

Thanks.

Disclaimer:
I know next to nothing about mhsample, so all I can do is check the code for
illogical, ambiguous and inefficient parts (found none), fix the texinfo
header (usually the hardest part for new contributors; not that I'm much of a
texinfo guru), and check style (found a few thingies). Plus check with on-line
Matlab examples I can find but I suppose you've already done that (?)
Any functional bugs will have to be catched by users working with the
function. (Perceive it this way: the Octave project doesn't really differ much
there from many commercial SW vendors :-) )

While reviewing I got a few questions:
0 Which property/value pairs are absolutely indispensable and which ones are
optional?
0 How about a statement 'axis equal' after the last mesh command in the first
demo to make the plot look better?
As to seealso, I think we find it undesirable to refer to unimplemented
functions there.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10016>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/