[Octave-patch-tracker] [patch #10058] src/biosig.mk: update to v2.2.1

[Markus Mützel]

Follow-up Comment #6, patch #10058 (project octave):

I pushed the part that updates to the newer version of the library to the
release branch here:
https://hg.octave.org/mxe-octave/rev/fa5ce462f09d

Additionally, I prepared a patch that adds rules to build and install
"mexbiosig" with the Windows installer (see attachment).

I noticed that the tarball only contains the files for four .mex files.
IIUC, the biosig package for Matlab/Octave also consists of several .m files.
(Basically, the files in the "biosig4matlab" folder in the complete tarball.)
It might be more convenient for Octave users of your package if the package
tarball also contained those .m files. Otherwise, *only* the .mex files would
be installed.
Would you consider including those in the "inst" folder of the package
tarball?
If you do, it might also make sense to add a PKG_ADD file that calls
initialization commands when the package is loaded. IIUC, that could be mostly
identical to your install.m script.
See also:
https://octave.org/doc/v6.2.0/Creating-Packages.html


(file #51286)
    _______________________________________________________

Additional Item Attachment:

File name: mxe-opkg-biosig.patch          Size:5 KB
    <https://file.savannah.gnu.org/file/mxe-opkg-biosig.patch?file_id=51286>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10058>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/