[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 07/20] target/arm: Split out rebuild_hflags_a32
From: |
Alex Bennée |
Subject: |
Re: [PATCH v6 07/20] target/arm: Split out rebuild_hflags_a32 |
Date: |
Mon, 14 Oct 2019 17:17:39 +0100 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Richard Henderson <address@hidden> writes:
> Currently a trivial wrapper for rebuild_hflags_common_32.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/arm/helper.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 296a4b2232..d1cd54cc93 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -11106,6 +11106,12 @@ static uint32_t rebuild_hflags_m32(CPUARMState *env,
> int fp_el,
> return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags);
> }
>
> +static uint32_t rebuild_hflags_a32(CPUARMState *env, int fp_el,
> + ARMMMUIdx mmu_idx)
> +{
> + return rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);
> +}
> +
> static uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
> ARMMMUIdx mmu_idx)
> {
> @@ -11218,7 +11224,7 @@ void cpu_get_tb_cpu_state(CPUARMState *env,
> target_ulong *pc,
> flags = FIELD_DP32(flags, TBFLAG_A32, LSPACT, 1);
> }
> } else {
> - flags = rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);
> + flags = rebuild_hflags_a32(env, fp_el, mmu_idx);
> }
>
> flags = FIELD_DP32(flags, TBFLAG_A32, THUMB, env->thumb);
--
Alex Bennée
- Re: [PATCH v6 03/20] target/arm: Split out rebuild_hflags_common_32, (continued)
- [PATCH v6 04/20] target/arm: Split arm_cpu_data_is_big_endian, Richard Henderson, 2019/10/11
- [PATCH v6 02/20] target/arm: Split out rebuild_hflags_a64, Richard Henderson, 2019/10/11
- [PATCH v6 05/20] target/arm: Split out rebuild_hflags_m32, Richard Henderson, 2019/10/11
- [PATCH v6 06/20] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/11
- [PATCH v6 07/20] target/arm: Split out rebuild_hflags_a32, Richard Henderson, 2019/10/11
- Re: [PATCH v6 07/20] target/arm: Split out rebuild_hflags_a32,
Alex Bennée <=
- [PATCH v6 08/20] target/arm: Split out rebuild_hflags_aprofile, Richard Henderson, 2019/10/11
- [PATCH v6 09/20] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/11
- [PATCH v6 10/20] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/11
- [PATCH v6 11/20] target/arm: Hoist computation of TBFLAG_A32.VFPEN, Richard Henderson, 2019/10/11
- [PATCH v6 13/20] target/arm: Split out arm_mmu_idx_el, Richard Henderson, 2019/10/11