[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort"
From: |
John Snow |
Subject: |
[PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort" |
Date: |
Thu, 7 Jul 2022 00:02:58 -0400 |
In some container environments, there may be references to block devices
witnessable from a container through /proc/self/mountinfo that reference
devices we simply don't have access to in the container, and cannot
provide information about.
Instead of failing the entire fsinfo command, return stub information
for these failed lookups.
This allows test-qga to pass under docker tests, which are in turn used
by the CentOS VM tests.
Signed-off-by: John Snow <jsnow@redhat.com>
---
qga/commands-posix.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 0469dc409d4..950c9d72fe7 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1207,7 +1207,12 @@ static void build_guest_fsinfo_for_device(char const
*devpath,
syspath = realpath(devpath, NULL);
if (!syspath) {
- error_setg_errno(errp, errno, "realpath(\"%s\")", devpath);
+ if (errno == ENOENT) {
+ /* This devpath may not exist because of container config, etc. */
+ fs->name = g_path_get_basename(devpath);
+ } else {
+ error_setg_errno(errp, errno, "realpath(\"%s\")", devpath);
+ }
return;
}
--
2.34.3
- Re: [PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM, (continued)
[PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test, John Snow, 2022/07/07
[PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images, John Snow, 2022/07/07
[PATCH v3 04/13] tests/vm: switch centos.aarch64 to CentOS 8 Stream, John Snow, 2022/07/07
[PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD, John Snow, 2022/07/07
[PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort",
John Snow <=
[PATCH v3 07/13] tests/vm: remove duplicate 'centos' VM test, John Snow, 2022/07/07
[PATCH v3 08/13] tests/vm: add 1GB extra memory per core, John Snow, 2022/07/07
[PATCH v3 03/13] tests/vm: switch CentOS 8 to CentOS 8 Stream, John Snow, 2022/07/07