[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images |
|
Date: |
Thu, 7 Jul 2022 09:18:15 +0100 |
|
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Thu, Jul 07, 2022 at 12:02:59AM -0400, John Snow wrote:
> If the initial setup fails, you've permanently altered the state of the
> downloaded image in an unknowable way. Use 'cp' like our other test
> setup scripts do.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/vm/centos | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 05/13] tests/vm: update sha256sum for ubuntu.aarch64, (continued)
- [PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test, John Snow, 2022/07/07
- [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images, John Snow, 2022/07/07
- Re: [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images,
Daniel P . Berrangé <=
- [PATCH v3 04/13] tests/vm: switch centos.aarch64 to CentOS 8 Stream, John Snow, 2022/07/07
- [PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD, John Snow, 2022/07/07
- [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort", John Snow, 2022/07/07
- [PATCH v3 07/13] tests/vm: remove duplicate 'centos' VM test, John Snow, 2022/07/07
- [PATCH v3 08/13] tests/vm: add 1GB extra memory per core, John Snow, 2022/07/07