[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort"
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort" |
Date: |
Thu, 7 Jul 2022 09:17:02 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Thu, Jul 07, 2022 at 12:02:58AM -0400, John Snow wrote:
> In some container environments, there may be references to block devices
> witnessable from a container through /proc/self/mountinfo that reference
> devices we simply don't have access to in the container, and cannot
> provide information about.
>
> Instead of failing the entire fsinfo command, return stub information
> for these failed lookups.
>
> This allows test-qga to pass under docker tests, which are in turn used
> by the CentOS VM tests.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> qga/commands-posix.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM, (continued)
[PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test, John Snow, 2022/07/07
[PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images, John Snow, 2022/07/07
[PATCH v3 04/13] tests/vm: switch centos.aarch64 to CentOS 8 Stream, John Snow, 2022/07/07
[PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD, John Snow, 2022/07/07
[PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort", John Snow, 2022/07/07
[PATCH v3 07/13] tests/vm: remove duplicate 'centos' VM test, John Snow, 2022/07/07
[PATCH v3 08/13] tests/vm: add 1GB extra memory per core, John Snow, 2022/07/07
[PATCH v3 03/13] tests/vm: switch CentOS 8 to CentOS 8 Stream, John Snow, 2022/07/07