Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks

[Emanuele Giuseppe Esposito]

Am 18/07/2022 um 10:45 schrieb Emanuele Giuseppe Esposito:
> 
> 
> Am 15/07/2022 um 16:34 schrieb Hanna Reitz:
>> On 12.07.22 23:19, Emanuele Giuseppe Esposito wrote:
>>> Together with all _can_set_ and _set_ APIs, as they are not needed
>>> anymore.
>>>
>>> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
>>> ---
>>>   block.c                            | 196 -----------------------------
>>>   block/block-backend.c              |  33 -----
>>>   blockjob.c                         |  35 ------
>>>   include/block/block-global-state.h |   9 --
>>>   include/block/block_int-common.h   |   4 -
>>>   5 files changed, 277 deletions(-)
>>
>> Looks good!  I’d just like a follow-up commit that also drops
>> bdrv_try_set_aio_context(), so it’s all gone (I think that’s the final
>> remnant?).
>>
> 
> It's the same for me, I thought renaming bdrv_try_set_aio_context was a
> little bit unnecessary. You want to rename it to something else, or
> directly call bdrv_child_try_change_aio_context?

Wait we have 2 functions that need to be renamed:

- bdrv_child_try_change_aio_context, called only once in block-backend
because we need the ignore_child parameter.
- bdrv_try_set_aio_context, public, called everywhere, wraps
bdrv_child_try_change_aio_context setting ignore_child=NULL.

Name suggestions?


> 
> I agree with the rest of comments in this series :)
> 
> Emanuele
>