|
From: | Paolo Bonzini |
Subject: | Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_ |
Date: | Mon, 18 Jul 2022 18:30:50 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 |
On 7/12/22 23:19, Emanuele Giuseppe Esposito wrote:
+ /* No need to ignore `child`, because it has been detached already */ ignore = NULL; - child->klass->set_aio_ctx(child, s->old_parent_ctx, &ignore); + ret = child->klass->change_aio_ctx(child, s->old_parent_ctx, &ignore, + tran, &error_abort); g_slist_free(ignore); + tran_finalize(tran, ret ? ret : -1);
Should this instead assert that ret is true, and call tran_commit() directly?
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |