Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_

From:	Paolo Bonzini
Subject:	Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_
Date:	Tue, 19 Jul 2022 20:07:50 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 7/19/22 11:57, Emanuele Giuseppe Esposito wrote:


Wrapping the new drains in aio_context_acquire/release(new_context) is
not so much helpful either, since apparently the following
blk_set_aio_context makes aio_poll() hang.
I am not sure why, any ideas?

I'll take a look, thanks. In any case this doesn't block this series,it was just a suggestion and blk_do_set_aio_context can be improved on top.


Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [RFC PATCH 2/8] transactions: add tran_add_back, (continued)
- [RFC PATCH 1/8] block.c: assert bs->aio_context is written under BQL and drains, Emanuele Giuseppe Esposito, 2022/07/12
  - Re: [RFC PATCH 1/8] block.c: assert bs->aio_context is written under BQL and drains, Hanna Reitz, 2022/07/14
- [RFC PATCH 5/8] block: implement .change_aio_ctx in child_of_bds, Emanuele Giuseppe Esposito, 2022/07/12
  - Re: [RFC PATCH 5/8] block: implement .change_aio_ctx in child_of_bds, Hanna Reitz, 2022/07/15
- [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Emanuele Giuseppe Esposito, 2022/07/12
  - Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Hanna Reitz, 2022/07/15
  - Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Paolo Bonzini, 2022/07/18
  - Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Paolo Bonzini, 2022/07/18
    - Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Emanuele Giuseppe Esposito, 2022/07/19
    - Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Paolo Bonzini <=
    - Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_, Emanuele Giuseppe Esposito, 2022/07/20
- [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks, Emanuele Giuseppe Esposito, 2022/07/12
  - Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks, Hanna Reitz, 2022/07/15
    - Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks, Emanuele Giuseppe Esposito, 2022/07/18
    - Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks, Emanuele Giuseppe Esposito, 2022/07/18
- [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context(), Emanuele Giuseppe Esposito, 2022/07/12
  - Re: [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context(), Hanna Reitz, 2022/07/14
    - Re: [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context(), Emanuele Giuseppe Esposito, 2022/07/18
    - Re: [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context(), Emanuele Giuseppe Esposito, 2022/07/18
  - Re: [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context(), Vladimir Sementsov-Ogievskiy, 2022/07/20

Prev by Date: Re: [PATCH v9 00/21] job: replace AioContext lock with job_mutex
Next by Date: Re: [PATCH] hw/nvme: add trace events for ioeventfd
Previous by thread: Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_
Next by thread: Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_
Index(es):
- Date
- Thread