Re: [Qemu-devel] [PATCH V6 16/29] qapi event: convert RTC_CHANGE

[Paolo Bonzini]

Il 13/06/2014 23:27, Eric Blake ha scritto:
> > > >>     visit_start_struct(v, NULL, "", "RTC_CHANGE", 0, &local_err);
> > > >>     if (local_err) {
> > > >>         goto clean;
> > > >>     }
> Hmm, qmp_output_start_struct() never sets errp.
>
> > > >>
> > > >>     visit_type_int(v, &offset, "offset", &local_err);
> > > >>     if (local_err) {
> > > >>         goto clean;
> > > >>     }
> Likewise, qmp_output_type_int never sets errp.

I think it is better to produce correct error propagation even if it is 
unused.  We could add range-checking of enums, for example.

I guess all the NULLs for errp could become &error_abort, but it can be 
done after the merge.

Paolo